fix: progress is wrong for nested stacks#1474
Merged
aws-cdk-automation merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
The CDK CLI prints a `(current)/(total)` progress. However, the `(total)` counter is based off of the change set of the root stack, while the `(current)` counter is a count of all the stack deployment events that the CLI has seen, which includes events in nested stacks. Be sure to only increase the progress counter for root stack events. Pre-emptive FAQ: why not accurately reflect the total amount of changes in all nested stacks? Because we have chosen (and locked in using tests) that we are not creating change sets for nested stacks. So there's no way to predict how many changes there will be in the nested stacks before executing.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1474 +/- ##
==========================================
- Coverage 88.10% 87.99% -0.12%
==========================================
Files 74 74
Lines 10669 10669
Branches 1457 1452 -5
==========================================
- Hits 9400 9388 -12
- Misses 1241 1253 +12
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
otaviomacedo
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CDK CLI prints a
(current)/(total)progress.However, the
(total)counter is based off of the change set of the root stack, while the(current)counter is a count of all the stack deployment events that the CLI has seen, which includes events in nested stacks.Be sure to only increase the progress counter for root stack events.
Pre-emptive FAQ: why not accurately reflect the total amount of changes in all nested stacks? Because we have chosen (and locked in using tests) that we are not creating change sets for nested stacks. So there's no way to predict how many changes there will be in the nested stacks before executing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license