fix(s3deploy): empty sources leads to deployment error#37786
fix(s3deploy): empty sources leads to deployment error#37786mergify[bot] merged 3 commits intomainfrom
Conversation
|
PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
|
||||||||||||||
|
|
||||||||||||||
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 29 minutes 51 seconds in the queue, including 29 minutes 29 seconds running CI. Required conditions to merge
ReasonPull request #37786 has been dequeued The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. Required status check "validate-pr" is queued. HintYou should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 19 seconds in the queue, including 3 seconds running CI. Required conditions to merge
|
|
Comments on closed issues and PRs are hard for our team to see. |
In the refactor that converted some
Lazycalls to the Box API, a case was missed forBucketDeployment: when thesourcesproperty is empty. It should generate a custom resource with empty arrays as properties as well. Instead it's generatingundefined(resulting in the property not being present in the resource).Offending source:
Change it to
omitEmpty: false.Fixes #37784.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license