fix(backup): use Conditions instead of ListOfTags in BackupSelection#37787
Open
fix(backup): use Conditions instead of ListOfTags in BackupSelection#37787
Conversation
aws-cdk-automation
previously requested changes
May 7, 2026
…-tags (updating code to use Box.combine)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #37771
Closes #18911
Reason for this change
BackupSelectiongenerates aListOfTagsCloudFormation property instead ofConditions. This has two consequences:ListOfTagsuses OR semantics — a resource matching any tag is selected.Conditionsuses AND semantics — a resource must match all conditions. The AWS Console's "Tags - equal" filter usesConditions, so tag-based selections created via CDK behave differently than equivalent console-created selections.ListOfTagsonly supportsStringEquals.ConditionssupportsStringEquals,StringLike,StringNotEquals, andStringNotLike.Additionally,
TagOperationhad a placeholderDUMMYmember instead of the three missing operations, and theresourcesarray onBackupSelectionOptionsmixes ARN resources with tag conditions in a way that implies per-ARN scoping that doesn't exist in the underlying API.Description of changes
selection.ts: ReplaceslistOfTags: ListOfTagswith aconditions: Conditionsblock in the generated CloudFormation. Four per-operation arrays (stringEquals,stringLike,stringNotEquals,stringNotLike) accumulate conditions and are serialized using PascalCase keys (required becauseconditionsis typed asanyin the generated layer, bypassing CDK's camelCase→PascalCase transformation). ExtractsaddTagCondition()as a shared private method.selection.ts: AddstagConditions?: TagCondition[]toBackupSelectionOptions. This is the preferred way to add tag-based filtering — it makes clear at the API level that conditions are selection-wide, not scoped to a single ARN.resource.ts: AddsSTRING_LIKE,STRING_NOT_EQUALS,STRING_NOT_LIKEtoTagOperation; removesDUMMY. DeprecatesBackupResource.fromTag()in favor oftagConditions.BackupResource.fromTag()continues to work unchanged for backwards compatibility.Describe any new or updated permissions being added
None.
Description of how you validated changes
Checklist
This PR description was generated using Claude
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license