Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,7 @@ on:
branches: [ main ]

jobs:
lint-commits:
# Note: To re-run `lint-commits` after fixing the PR title, close-and-reopen the PR.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Use Node.js
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
with:
node-version: 22.x
- name: Check PR title
run: |
node "$GITHUB_WORKSPACE/.github/workflows/lintcommit.js"

build:
needs: lint-commits

runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down
178 changes: 0 additions & 178 deletions .github/workflows/lintcommit.js

This file was deleted.

6 changes: 3 additions & 3 deletions .github/workflows/test-parser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@ on:
pull_request:
paths:
- 'ops/parse_sdk_branch.py'
- 'ops/__tests__/**'
- 'ops/tests/**'
push:
branches: [ main ]
paths:
- 'ops/parse_sdk_branch.py'
- 'ops/__tests__/**'
- 'ops/tests/**'

permissions:
contents: read
Expand All @@ -21,4 +21,4 @@ jobs:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Run parser tests
run: python ops/__tests__/test_parse_sdk_branch.py
run: python ops/tests/test_parse_sdk_branch.py
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ There is a convenience script for the above that you can run from the root of th
ops/ci-checks.sh
```

This script also validates your commit messages against the [Conventional Commits](https://www.conventionalcommits.org/) format.
Commit all your changes before you run the check. If your working directory is dirty the script will skip commit message validation with a warning.

You can also run the commit message check independently:
```
python ops/lintcommit.py
```

## Coding Standards
Consistency is important for maintainability. Please adhere to the house-style of the repo, unless there's a really
good reason to break pattern.
Expand Down
1 change: 1 addition & 0 deletions ops/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@

3 changes: 3 additions & 0 deletions ops/ci-checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ echo SUCCESS: typings
# static analysis
hatch fmt
echo SUCCESS: linting/fmt

# commit message validation
python ops/lintcommit.py
Loading
Loading