Open
Conversation
d2fc35b to
4dfe282
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Addresses #5414
S3's RestXML protocol sends the response's error information in the response body. Since S3 head* operations do not have a body, we need to infer what kind of exception it is from the error message. In case of throttling, S3 will send:
We need to grab the status code (503) and status text ("Slow Down") and use those two to infer that the server throttled the request.
We already have an execution interceptor for S3 that extracts info from head operation responses. All this PR does is adds one more logic branch that handles extracting the error info from the slow down responses, and create the appropriate S3Exception that will get classified as ThrottlingException and will apply the appropriate retry mechanism