Repository navigation
Merge main and update for 1.0.0 (into #1631) - #1663
Closed
ekjotmultani wants to merge 5 commits into
Closed
ekjotmultani wants to merge 5 commits into
ekjotmultani wants to merge 5 commits into
Conversation
The generator returned raw StringBuffer output from every sink, so generated clients failed `dart format`. generate() now formats the complete unit with dart_style using the target package language version from package_config for build_runner and CLI, with Dart 3.11 fallback. It prepends `// dart format width=80` so output is stable regardless of consumer page_width. Dart goldens were regenerated.
Take main's Dart goldens and regenerate them with this branch's formatter.
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:21 — with
GitHub Actions
Inactive
ekjotmultani
temporarily deployed
to
agent-bench
November 19, 2026 09:52 — with
GitHub Actions
Inactive
Contributor
📖 Glossary & notes — scoring, indicators, per-metric thresholds (click to expand)
Results — PR vs
|
| Task | Template | Tests | Judge | Cost | Turns | Score | Stop reason |
|---|---|---|---|---|---|---|---|
| async-word-counter | bare | ✅ 13/13 (0) | ✅ 9.6 (0) | ❌ $8 (+$4.54) | ❌ 36 (+18) | ❌ 12.3 (-16.1) | endTurn |
| auth-notes | demo | ✅ 11/11 (0) | ✨ 9.6 (+1.2) | ❌ $34.76 (+$8.24) | ❌ 69 (+9) | ✅ 2.8 (-0.7) | endTurn |
| cognito-profile | auth | ✅ 10/10 (0) | ✨ 9 (+0.4) | ✨ $19.78 (-$6.77) | ✨ 57 (-10) | ✅ 4.9 (+1.3) | endTurn |
| collab-presence-board | default | ✅ 11/11 (0) | ✅ 9.4 (-0.2) | ✅ 24.3 (-4.9) | endTurn | ||
| email-digest | demo | ✅ 12/12 (0) | ✅ 9.2 (+0.2) | ✨ $4.17 (-$0.93) | ✨ 19 (-8) | ✅ 23.2 (+4.4) | endTurn |
| file-gallery | bare | ❌ 7.8 (-1.6) | ✨ $2.9 (-$0.95) | ✅ 14 (-3) | ✅ 28 (+2.6) | endTurn | |
| kb-chat-agent | demo | ✅ 9/9 (0) | ✅ 8.8 (0) | ✨ $23.06 (-$7.75) | ✨ 47 (-10) | ✅ 4.1 (+1) | endTurn |
| observability-api | backend | ✅ 18/18 (0) | ✨ 9.6 (+0.6) | ❌ $25.73 (+$17.59) | ❌ 54 (+8) | endTurn | |
| oidc-dsql-notes | react | ✅ 11/11 (0) | ✅ 9.4 (+0.2) | ✨ $27.1 (-$18.17) | ✨ 59 (-33) | ✅ 3.6 (+1.5) | endTurn |
| sql-kb-catalog | nextjs | ✅ 9/9 (0) | ✨ $7.21 (-$3.37) | ✨ 26 (-8) | ✅ 13.2 (+4) | endTurn |
Merge verdict
✅ This bench run does not block the PR.
- ✅ Absolute floor — mean composite 95.5 >= floor 65.
- ✅ Regression vs
main— mean composite delta -0.9 pts vs main is within the 10-pt limit.
The Δ vs base ball above is a fixed ±5-pt display band; the regression gate uses BENCH_MAX_REGRESSION. The ball is cosmetic — the gate threshold is what blocks.
3 tasks done
cadivus
force-pushed
the
fix/dart-codegen-format-output
branch
from
November 19, 2026 13:03
db9a94e to
b397b92
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merges
maininto #1631 so it can land in Dart 1.0.0. #1574, #1578, #1599 and #1481 merged after this branch was cut, and all of them regenerated the Dart goldens.origin/main. Every Dart golden conflicted, so I took main's side and regenerated all of them with this branch's formatter (REGENERATE_FIXTURES=1 dart test test/golden_file_test.dart). Fixtures 44 and 45 are new on main and are now formatted too. Fixture 35 stays acodegen-error.txtgolden. The only source conflict was the CHANGELOG: the formatting bullet sits at the top of### Other changes, and nothing from## 0.2.0down changed.scripts/sink-guards/codegen.test.mjspinned thetoStringwriteln ingenerator.dartat 2168, which matched no site after the merge. The same line is now at 2175.open_union_test.dartandopen_enum_test.dart(from feat(native-codegen): decode enum values and union arms a client doesn't know #1481) matched one-line snippets that the formatter splits. They now usedart_source_matchers.dart'scontains, like the other tests here.dart_styleandpub_semveras lowercasebsd-3-clause, which the action rejects as an invalid SPDX id. This adds both toallow_dependencies_licenses, as fix(dart): drop the analyzer cap, accept build 4 and 5, and allow build's lowercase license #1474 did forbuild. The "could not detect a license" line forpackage_configis informational;httpgets the same line on main and passes.Swift and Kotlin goldens are unchanged. This merges cleanly with #1575 in either order.
You can merge this into your branch as is, or pull your local changes first and then merge it. Drop or reword anything you like.