Improve error details and handle proxy connection errors#1650
Merged
Improve error details and handle proxy connection errors#1650
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1650 +/- ##
===========================================
+ Coverage 47.81% 63.88% +16.06%
===========================================
Files 382 396 +14
Lines 8525 9247 +722
Branches 3159 3521 +362
===========================================
+ Hits 4076 5907 +1831
+ Misses 3070 2310 -760
+ Partials 1379 1030 -349
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
77e4d51 to
c5d8a97
Compare
- Fix ErrorDetails.message type to allow undefined
- Hide error message field in dialog when undefined
- Consolidate extractMessageFromData into extractErrorMessage
- Add comment explaining serializeCause name handling
- Add tests for NetworkError and fetchDatabaseRequest
- Simplify decodeErrorSafely to return raw text for non-JSON responses
instead of wrapping in { message } since extractErrorMessage handles
strings directly
c5d8a97 to
244c86a
Compare
arseny-kostenko
approved these changes
Apr 8, 2026
* Add security policy and security audit workflow * Address review feedback for security audit workflow * Remove pnpm audit step from security audit workflow * Remove SLA and public issue instruction
* Remove ExplorerInjector component The ExplorerInjector was originally added to inject the explorer instance into the query client meta field and clear the cache on connection change. Both responsibilities are already handled elsewhere: - The store is injected at query client creation time in createQueryClient() - Cache clearing happens via queryClient.removeQueries() in useResetState(), which is called at every connection switch point Resolves aws#1646 * Add tests for createQueryClient and useResetState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Incremental improvements to error handling and display, building on #1644:
ServerConnectionErrorfor whenfetchfails to reach the server, capturing the request URL and original cause for diagnosticsextractMessageFromDataincreateDisplayError.tsinto the sharedextractErrorMessageutility and move it fromconnector/toutils/decodeErrorSafelyto return raw text for non-JSON responses instead of wrapping in{ message }, sinceextractErrorMessagehandles plain strings directlystatusTextlookup toNetworkErrorfor human-readable status names in error detailsErrorDetails.messagetostring | undefinedand conditionally hide the message field in the error details dialog when undefinedserializeCausesetsnameexplicitly (it lives on the prototype, not as an own property)TypeErrorexceptions fromfetch()asServerConnectionErrorfor cross-browser compatibility (Chrome, Firefox, Safari use different messages for network failures)hasOriginMismatchparameter type fromstring | undefinedtostringfetchDatabaseRequest,NetworkError,ServerConnectionError,createDisplayError, andcreateErrorDetailsValidation
pnpm checkspasses (lint, format, types)pnpm testpasses with no failuresRelated Issues
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.