Open
Conversation
4268c4c to
5b26f4e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
===========================================
+ Coverage 47.81% 72.58% +24.76%
===========================================
Files 382 408 +26
Lines 8525 12265 +3740
Branches 3159 3518 +359
===========================================
+ Hits 4076 8902 +4826
+ Misses 3070 2343 -727
+ Partials 1379 1020 -359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds pnpm supply chain hardening settings and tightens the Dockerfile and CI install steps based on a review of npm security best practices.
strictDepBuilds: true— Failpnpm installif any dependency tries to run a build script that hasn't been explicitly allowed.core-jsis added toignoredBuiltDependenciesto suppress its sponsorship postinstall.onlyBuiltDependencies: [esbuild]— Explicitly allow theesbuildpostinstall script, which installs the platform-specific binary.blockExoticSubdeps: true— Prevent transitive dependencies from resolving to git repos or raw tarball URLs.trustPolicy: no-downgrade— Refuse to install a package version whose publish-time trust evidence (provenance, signatures) is weaker than a previously published version.--frozen-lockfileon both Dockerfile install steps and the CI unit test workflow, ensuring deterministic installs.--ignore-scriptskept on the production install in the Dockerfile as defense-in-depth.docs/development.mdexplaining the supply chain settings and what to do whenpnpm installrejects a dependency.Validation
pnpm install --frozen-lockfilesucceeds locally with all new settingsRelated Issues
None
Check List
pnpm checkspasses with no errors.pnpm testpasses with no failures.