fix: rename lr_warmup_ratio to lr_warmup_steps_ratio to match recipe#428
Merged
aviruthen merged 1 commit intoJun 4, 2026
Merged
Conversation
jam-jee
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SageMaker Hub recipes renamed the hyperparameter lr_warmup_ratio to lr_warmup_steps_ratio. This affects all recipes (confirmed on Qwen/Qwen3-4B and meta-llama/Llama-3.1-8B). The CLI's configure command dynamically generates options from the recipe schema, so the actual CLI option is now --lr-warmup-steps-ratio. Updating the parameter name accordingly
What's changing and why?
Before/After UX
Before:
After:
How was this change tested?
Are unit tests added?
Are integration tests added?
Reviewer Guidelines
One of the following must be true: