Skip to content

fix(remote): remove -U flag from auto-injected sagemaker requirements install #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nileshpatil6 wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −4
Open

fix(remote): remove -U flag from auto-injected sagemaker requirements install #5922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35caefc
fix(remote): remove -U flag from requirements.txt pip install
nileshpatil6 Jun 3, 2026
b6cf5cf
Merge branch 'master' into fix/remote-decorator-drop-pip-upgrade-flag
nileshpatil6 Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ore/src/sagemaker/core/remote_function/runtime_environment/runtime_environment_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def _install_requirements_txt(self, local_path, python_executable):
"""Install requirements.txt file"""
# Validate path to prevent command injection
validated_path = self._validate_path(local_path)
cmd = [python_executable, "-m", "pip", "install", "-r", validated_path, "-U"]
cmd = [python_executable, "-m", "pip", "install", "-r", validated_path]
logger.info("Running command: '%s' in the dir: '%s' ", " ".join(cmd), os.getcwd())
_run_shell_cmd(cmd)
logger.info("Command %s ran successfully", " ".join(cmd))
Expand All @@ -320,7 +320,7 @@ def _install_req_txt_in_conda_env(self, env_name, local_path):
self._validate_env_name(env_name)
validated_path = self._validate_path(local_path)

cmd = [self._get_conda_exe(), "run", "-n", env_name, "pip", "install", "-r", validated_path, "-U"]
cmd = [self._get_conda_exe(), "run", "-n", env_name, "pip", "install", "-r", validated_path]
logger.info("Activating conda env and installing requirements: %s", " ".join(cmd))
_run_shell_cmd(cmd)
logger.info("Requirements installed successfully in conda env %s", env_name)
Expand Down
4 changes: 2 additions & 2 deletions ...in/src/sagemaker/train/remote_function/runtime_environment/runtime_environment_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def _install_requirements_txt(self, local_path, python_executable):
"""Install requirements.txt file"""
# Validate path to prevent command injection
validated_path = self._validate_path(local_path)
cmd = [python_executable, "-m", "pip", "install", "-r", validated_path, "-U"]
cmd = [python_executable, "-m", "pip", "install", "-r", validated_path]
logger.info("Running command: '%s' in the dir: '%s' ", " ".join(cmd), os.getcwd())
_run_shell_cmd(cmd)
logger.info("Command %s ran successfully", " ".join(cmd))
Expand All @@ -320,7 +320,7 @@ def _install_req_txt_in_conda_env(self, env_name, local_path):
self._validate_env_name(env_name)
validated_path = self._validate_path(local_path)

cmd = [self._get_conda_exe(), "run", "-n", env_name, "pip", "install", "-r", validated_path, "-U"]
cmd = [self._get_conda_exe(), "run", "-n", env_name, "pip", "install", "-r", validated_path]
logger.info("Activating conda env and installing requirements: %s", " ".join(cmd))
_run_shell_cmd(cmd)
logger.info("Requirements installed successfully in conda env %s", env_name)
Expand Down
Loading