fix: prevent duplicate dotenv key mass-deletion from keys view#5
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
fix: prevent duplicate dotenv key mass-deletion from keys view#5cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug and impact
In the dotenv Keys view, clicking Remove on a key used key-based deletion (
removeDotenvKey) that removes every matching key line. For files with duplicate keys (common during merges or staged rotations), one click could silently delete multiple values and persist them on save.Root cause
The UI rendered duplicate entries distinctly by row index, but removal was implemented by key name only, collapsing all duplicates into one deletion operation.
Fix
removeDotenvEntryAt(content, entryIndex)insrc/lib/dotenv-parse.ts.file-workspace.tsxto pass the displayed row index to removal and callremoveDotenvEntryAt.removeDotenvKeyunchanged for existing callers.Validation
src/lib/dotenv-parse.test.tswith regression coverage for duplicate keys and preservation of comments/blank lines.npm test -- src/lib/dotenv-parse.test.ts(passes).