fix(docs): add missing await on provider.request() calls in README#274
Open
ygd58 wants to merge 1 commit intobase:masterfrom
Open
fix(docs): add missing await on provider.request() calls in README#274ygd58 wants to merge 1 commit intobase:masterfrom
ygd58 wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
ygd58
force-pushed
the
fix/readme-missing-await-provider-request
branch
from
e887525 to
192a1a3
Compare
Author
|
hey @fan-zhang-sv @spencerstock can you take a look when you get a chance? |
ygd58
force-pushed
the
fix/readme-missing-await-provider-request
branch
from
192a1a3 to
16ef6d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was going through the README and noticed two code examples are missing await on provider.request() calls. Since provider.request() returns a Promise, without await the const addresses variable ends up being a Promise object instead of an array of addresses. Anyone following these examples will run into unexpected behavior. Lines 176 and 184 in README.md.