ci: grant release-please issues permission#284
Closed
fan-zhang-sv wants to merge 1 commit intomasterfrom
Closed
Conversation
Made-with: Cursor
Collaborator
🟡 Heimdall Review Status
|
Contributor
Review SummaryPR title: Change: Adds Assessment: No issues found. This is a minimal, well-justified fix.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issues: writeto the Release Please workflow token permissions.commit-batch-size: 1mitigation in place.Why
The release-please workflow is still failing inside GitHub Actions while executing the first commit-history GraphQL query, even after reducing the commit batch size to 1.
I reproduced the reduced release-please GraphQL query locally with
gh api graphql, and it succeeds againstmaster. The remaining difference is the token used in Actions: the workflow usessecrets.GITHUB_TOKENwith onlycontents: writeandpull-requests: write.Release Please's documented required workflow permissions include
issues: writeas well:https://github.com/googleapis/release-please-action?tab=readme-ov-file#workflow-permissions
That permission is relevant because release-please reads PR labels in the failing GraphQL query and may create/update labels on release PRs.
Test plan
issues: write.master.Made with Cursor