Conditional AMD 395 Chromium/Brave crash fix#5993
Open
andyjeffries wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a hardware fix for Strix Halo (Ryzen AI Max+ 395) systems where Chromium-based browsers have broken VA-API video acceleration, by appending flags that disable hardware video decode/encode to Chromium and Brave flag config files.
Changes:
- New install script that detects the Strix Halo CPU and appends VA-API-disabling flags to
chromium-flags.confandbrave-flags.conf. - Wired the new script into
install/config/all.sh. - Migration that runs the fix for existing installations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| install/config/hardware/amd/strix-halo-chromium-vaapi.sh | New script that conditionally appends Chromium/Brave flags on Strix Halo. |
| install/config/all.sh | Invokes the new hardware fix during config. |
| migrations/1779745014.sh | Migration to apply the fix on existing systems. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+21
to
+22
| add_chromium_vaapi_flags ~/.config/chromium-flags.conf | ||
| add_chromium_vaapi_flags ~/.config/brave-flags.conf |
Author
There was a problem hiding this comment.
This is a good point, but I don't know enough about Omarchy's internals to know who it's running as at this point of the process to know which to use 🤷♂
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dhh something like this (referring to #5478 (comment))
I've never built anything in/for Omarchy before, so if this isn't what you were intending, let me know and I'll re-work it. Hopefully I've understood Omarchy well enough that it's what you thought of.