Source collected by query parameter#183
Open
johnbilt wants to merge 12 commits into
Open
Conversation
samdbmg
reviewed
Apr 20, 2026
| This behaviour focuses on starting from a known Flow to which the collection is applied. | ||
| There is no equivalent endpoints at the Source level. | ||
|
|
||
| If chosen to also apply at the Flow level then need to consider is `flows_collected_by_id=a46c49f1-4764-42b9-9f91-f267a58903c4` too similar to `/flows/a46c49f1-4764-42b9-9f91-f267a58903c4/flow_collection`? |
Member
There was a problem hiding this comment.
The distinction kinda comes up for the role discussion in #173 - the query string parameter lets you search for more things, for example /flows?flows_collected_by_id=<uuid>&format=urn:x-nmos:format:video&codec=video/h264 which feels useful, while the flows/<uuid>/flow_collection is the canonical resource itself - you can edit it there
Member
|
TSC 2026-05-01 |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Currently at the Source level there is no filtering on the
collected_byfield.When vendors are building systems which list content stored in TAMS then they are only looking for the Sources at the top of the content tree.
This PR is to add the ability to filter Sources (and Flows) to find the content which is not collected by another Source and therefore is the top level.
Jira Issue (if relevant)
Jira URL:
Related PRs
Where appropriate. Indicate order to be merged.
Submitter PR Checks
(tick as appropriate)
Reviewer PR Checks
(tick as appropriate)
Info on PRs
The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.