Merged
Conversation
This reverts commit 19239f5.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the existing deepCSA regressions implementation with a new bbgregressions-based subworkflow, wiring it into the main DEEPCSA workflow and updating pipeline configuration/schema accordingly.
Changes:
- Swap legacy
RUNREGRESSIONS+ in-repo Python regression scripts for newbbgregressionsNextflow modules (edit config → create inputs → fit models → plot). - Update pipeline parameter schema/config to expose the new
bbgr_*knobs and add a newtest_regressionsprofile/config. - Add default bbgregressions YAML configs for mutdensity/omega/omega globalloc regressions and update publishDir routing for the new outputs.
Reviewed changes
Copilot reviewed 15 out of 22 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| workflows/deepcsa.nf | Rewires the regressions block to call the new REGRESSIONS* subworkflows with bbgregressions inputs. |
| subworkflows/local/regressions/main.nf | Replaces legacy regressions workflow with EDITCONFIG → CREATE_INPUT → MODELS → PLOT steps. |
| conf/tools/regressions.config | Replaces old regressions params with new bbgr_* params and default config paths. |
| nextflow_schema.json | Updates schema for the new regressions parameters and UI grouping. |
| modules/local/bbgtools/bbgregressions/editconfig/main.nf | Adds a process to produce the final per-run bbgregressions config. |
| modules/local/bbgtools/bbgregressions/create_input/main.nf | Adds a process to generate regression inputs via bbgregressions. |
| modules/local/bbgtools/bbgregressions/regressions/main.nf | Adds a process to run bbgregressions model fitting. |
| modules/local/bbgtools/bbgregressions/plot/main.nf | Adds a process to plot regression results via bbgregressions. |
| modules/local/bbgtools/bbgregressions/*/meta.yml | Adds module metadata files (currently empty). |
| conf/modules.config | Adds publishDir routing for the new regressions subworkflow outputs and removes legacy RUNREGRESSIONS config. |
| nextflow.config | Adds a test_regressions profile including a new test config file. |
| conf/deepcsa_config_bbgregressions_test.config | Introduces a regressions-oriented test profile configuration. |
| bin/regressions_editconfig.py | New helper script to tailor bbgregressions config based on mode/metric (and omega QC results). |
| modules/local/runregressions/main.nf | Removes legacy regressions process. |
| bin/regression_analysis.py | Removes legacy regression analysis runner. |
| bin/utils_regressions.py | Removes legacy regression helper utilities. |
| assets/regressions/configs/mutdensity.yml | Adds default bbgregressions config for mutdensity. |
| assets/regressions/configs/omega.yml | Adds default bbgregressions config for omega. |
| assets/regressions/configs/omegaglobal.yml | Adds default bbgregressions config for omega global-loc. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FerriolCalvet
commented
Apr 8, 2026
Member
Author
FerriolCalvet
left a comment
There was a problem hiding this comment.
see #442 for some comments on things that should be updated soonish
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New implementation of the regressions module using the bbgregressions tool!