Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rap-client-binding-prototype-20260920
…rap-client-binding-prototype-20260920
…wrap-client-binding-prototype-20260920
Owner
Author
|
Integrated through reviewed implementation PR #362, merged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Prototype explicit runtime binding for #340 on the accepted callable compiler commit
42feeca0abd1314592be691faa6d608541dfc6d2.call; handle disposal does not dispose the bridge.Verification
CI run 35503626271 passed all 22 jobs at
65bed9577254e68566827496a9693223da1e3e05. The Node 22 and Python 3.11 job passed 10 prototype tests. The matrix includes Python 3.10 and 3.12, Bun, macOS, and Windows.The tests cover two Python environments for one module, concurrent and interleaved calls, class and static methods, overloads, generics, optional and keyword arguments, bytes, failures, borrowing and disposal, mixed Node and HTTP bridges, reloads, and a consumer TypeScript check. The default generated bytes remain unchanged in the fixture test.
An independent review found and reproduced a provenance flaw in the earlier renderer. The corrected head derives both generated forms internally from the same module. The reviewer accepted the corrected internal prototype after the full CI pass.
In the CI size test,
binding_fixturesource grew from 7,300 to 10,113 bytes and declarations from 1,897 to 5,023 bytes.advanced_typessource grew from 22,779 to 28,918 bytes and declarations from 11,236 to 24,377 bytes. A public option needs a package and editor size budget.Remaining production work
This draft does not add a public
generate()option, package export, output-path collision checks, optional declaration handling, or configured output formats. The integration must rejectoutput.sourceMapbefore calling this renderer until all emitted files support maps. The defaultgenerate()path is unchanged. This PR closes no issue and is not release acceptance.