Skip to content

Integrate callable coroutine types with runtime fixtures - #357

Closed
bbopen wants to merge 63 commits into
codex/tywrap-coroutines-final-integration-20260920from
codex/tywrap-coroutine-capability-followup-20260920
Closed

bbopen wants to merge 63 commits into
codex/tywrap-coroutines-final-integration-20260920from
codex/tywrap-coroutine-capability-followup-20260920

Conversation

@bbopen

@bbopen bbopen commented Sep 20, 2026 •

Copy link
Copy Markdown
Owner

Scope

This draft combines the accepted callable compiler branch (PR #347, 42feeca), accepted conformance evidence (1736b68), and the coroutine integration branch (PR #352, 6d5fed9). It adds generated Node and real Pyodide checks for Promise<string> source and declarations, zero generation warnings, and execution through the bound runtime.

The merge preserved the coroutine subprocess, Pyodide, and pool source from PR #352. It preserved the callable compiler and IR model files from PR #347.

Evidence

  • All three input heads are ancestors of this branch.
  • The combined diff has no unresolved conflicts or whitespace errors.
  • Exact-head CI on 54cef7c passed all 24 jobs, with no skipped jobs. The Node coroutine suite passed 20 tests. The real Pyodide suite passed all 8 tests, including generated asyncText execution and timeout cancellation followed by reuse.
  • An independent read-only review at 54cef7c found no actionable issue in the merged RPC client, source provenance, or generated wrapper tests.
  • An earlier run on db77710 failed snapshot and consumer gates with provisional compiler and conformance heads. This branch uses the accepted heads, and its full CI run passed.
  • The original runtime PRs remain draft and unchanged.

Boundary

The default coroutine capability applies to wrappers bound to the current tywrap bridges. An external or older HTTP provider may lack it; the compiler retains an explicit unavailable control. The real Pyodide test loads an equivalent fixture into sys.modules; it does not import the analyzed temp file inside WASM. Generic TypeVar runtime validation remains separate work.

Refs #338.

…wrap-callable-compiler-20260919

# Conflicts:
#	docs/maintainers/value-contract-fixtures.v2.json
#	docs/maintainers/value-contracts.md
#	docs/maintainers/value-contracts.v2.json
#	src/contracts/value-contract.ts
# Conflicts:
#	src/runtime/decoded-provenance.ts
#	src/types/index.ts
#	test/decoded_provenance.test.ts
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added area:docs Area: documentation area:ci Area: CI and automation area:runtime area:codegen area:types labels Sep 20, 2026
@bbopen

bbopen commented Sep 20, 2026

Copy link
Copy Markdown
Owner Author

Integrated through reviewed implementation PR #362, merged as 43f111b43fbb0ce31dcb59f8fb489e8dadf3f191. This branch head is an ancestor of that merged commit. Final combined release candidate aa5497f867b36a76670afedbe9b34a6712a322e3 passed full CI 35508107651. Closing this component PR because its work is already on main; release publication is tracked by #354.

@bbopen bbopen closed this Sep 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:ci Area: CI and automation area:codegen area:docs Area: documentation area:runtime area:types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant