Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Integrated through reviewed implementation PR #362, merged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
This draft prototypes semantic value-contract revision 3 on top of the frozen callable compiler. Revision 2 stays the default safe-number policy. The v3 manifest pins the LF-normalized revision-2 source hash and adds one
integer-exactleaf. Contract revision 3, integer envelope codec version 2, per-call policybigint-v2, and RPC protocoltywrap/1remain separate labels.EXACT_INTEGER_VALUE_CONVERSIONmaps opted Pythonintvalues tobigint. The generator uses the resolved contract for parameters and returns, including nested composites, overloads, static and class methods, and simple variadic forms. Generated validators require primitive bigint at each exact node. The compiler refuses to emit an exact wrapper under revision 2 or without the explicitexact-integer-adaptercapability. That capability is unavailable by default. A mixed named keyword-only plus exact**kwargsshape fails closed because TypeScript cannot state its index rule precisely.The default bridge, protocol, and Arrow int64 path are unchanged. This PR does not add a public per-callable mode or production bigint support.
Relates to #337. The PR targets the compiler branch to keep the v3 diff separate.
Evidence
1862f3epassed the full matrix, including Windows.Open gates
meta.valueCapabilitiesbefore any tagged request, then rerun against the integrated source.