Repository navigation
fix: close failed ping response bodies - #246
Merged
Merged
Conversation
Owner
|
Expect a new release by Oct 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
HTTP retries leave discarded response bodies open. Failed pings also return before closing the final response, so repeated failures retain connections.
Close discarded responses before retrying. Keep the final response available to
Postcallers, and close it inpingon success or failure.Seven regression cases fail before the fix. They cover successful retries, exhausted retries and permanent errors, with controls for successful responses and direct
Postcallers.go test -race ./...,./scripts/buildandgo vet ./...pass on Go 1.27.0. Formatting is clean.The built client also passes three HTTP scenarios in the project's Docker image, including retry payloads and connection cleanup.