Repository navigation
watch_applied: report how long a store apply has been in flight - #35
Merged
Merged
Conversation
A store apply runs on a blocking task with no timeout. If it never returns, the watch stops advancing while the rest of the process stays healthy, and nothing tells the consumer. Add ApplyProbe through BatchConfig::apply_probe. in_flight() returns the age of the current apply, counted from handoff to the blocking pool, so time spent waiting for a blocking thread is included. A guard held by the blocking task clears it when the apply returns, panics or never starts. BatchConfig is no longer Copy, so this is 0.9.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnapshotStore::applyruns on a blocking task with no timeout. If it hangs, the watch stops advancing while the rest of the process stays healthy, and the consumer has no signal.This adds
ApplyProbe, set throughBatchConfig::apply_probe.probe.in_flight()returns the age of the current apply, counted from handoff to the blocking pool. It clears when the apply returns, panics, or never starts.BatchConfigis no longerCopy, so this bumps to 0.9.0.BatchConfig::default()callers do not change. Merging publishes the release.Verified
cargo test --lib --tests --features fjall,rocksdb,transport: all pass, including Stateright models and DST; the MinIO tests pass run seriallycargo test --lib --testswith model-named tests skipped: passcargo fmt --check,dprint check,cargo clippy --all-targets --all-features -- -D warnings,cargo doc --no-deps --all-features🤖 Generated with Claude Code