Repository navigation
[pull] main from openai:main - #41
Merged
Merged
Conversation
## Why Concurrent test spawns can inherit a writable descriptor for the MCP server wrapper, causing `ETXTBSY` when launching it on Linux. ## What changed Write the wrapper through a separate `/bin/sh` process on Linux so its writable descriptor stays out of the test process. Check the writer's exit status and include stderr on failure. Retain direct file writes on other Unix platforms. GitOrigin-RevId: f99952ec000ba7317243e87fd664dc0e31bb7b24
## Why Guardian needs the assistant's delivered question to interpret a user's reply. Messages sent through nested Code Mode tools must remain available as review context, and approvals based on earlier context must become stale when a new delivery is confirmed. Assistant messages do not themselves grant authorization. ## What changed - Capture successful hosted User Messaging sends after input rewriting and before result callbacks or post-tool hooks. - Retain bounded delivery text in acceptance order, persist it through cancellation and shutdown, and preserve it across compaction and resume with an older-client-compatible rollout encoding. - Track assistant review context separately from user authorization, invalidating pending and cached approvals for both local and worker reviews when that context changes. - Associate retained deliveries with the correct instruction or communication boundary during rollback. ## Testing Add coverage for nested messaging review context, fast replies and communication ordering, shutdown persistence, stale local and worker approvals, rollout compatibility, and rollback retention. GitOrigin-RevId: 1bc1ec9e8947560b99f4b39a42ddb9f2099f519b
…48727) ## Why Concurrent tests can inherit writable descriptors for executable fixtures, causing `ETXTBSY` when those fixtures launch on Linux. ## What changed Expose shared `write_executable` and `copy_executable` helpers from `codex_utils_cargo_bin` and adopt them in CLI, exec-server, and MCP tests. On Linux, writes and copies complete in separate processes so sibling test spawns cannot inherit the writable descriptors. Script fixtures receive mode `0o755`, and copied executables retain their source permissions. Remove the executable-busy retry loop from the program resolver test now that its script uses the shared helper. GitOrigin-RevId: 61624158190bb1e75c27d9eb9c87a2defc147fb7
## Why The status card truncates values in narrow terminals, hiding parts of paths, session IDs, and other details. ## What changed - Remove the status border and wrap values with continuation lines aligned beneath the value column, falling back to less indentation at very narrow widths. - Preserve full directory paths and session IDs in displayed and copied status output. - Allow history updates with no previous rows to append new details while preserving existing history rows. ## Testing Add regression coverage for long Unicode paths and session IDs across terminal widths, copied text, usage links, and appending late thread-usage details. Update status snapshots for the borderless layout and wrapped values. GitOrigin-RevId: e059fed5b45e15b76250b684f1760797442eabce
## What changed Replace the continuous two-second shimmer with a 600 ms initial delay and a one-second sweep every four seconds, matching the desktop app's thinking and reasoning header timings. ## Testing Update snapshots for short, long, and Unicode labels in both themes to cover the initial delay, sweep, gap, and next sweep. Sample smoothness across two sweeps at 32 ms intervals and adjust the brightness-change bound for the faster sweep. GitOrigin-RevId: d7a6a81db99bf0e8a73eee0c67eb7e44d4d76f42
## What changed Replace generic output disclosure labels with counts such as `+ 5 lines (ctrl+t to expand)` for compact command activity, both live and in history. Count retained output lines hidden or clipped by the preview, excluding output discarded by storage limits. Use the configured `open_transcript` shortcut and omit the hint when it does not fit or the action is unbound. Invalidate cached layouts when keybindings change. Keep generic `Show details` labels for other hidden details and keep disclosure controls outside copyable and searchable text. ## Testing Add regression tests for live/history consistency, remapped and disabled shortcuts, and exclusion of hints from source text. Add snapshot coverage for fully visible output, hidden and clipped lines, command-only details, and storage-truncated output. GitOrigin-RevId: c468be9b88b69dc3ca1abdb6b7be023244d32a57
## Why Defaulting missing or unsupported display preferences to `inline` prevents clients from applying resource display defaults. ## What changed Populate `mcpAppUi` only when a tool descriptor has a resource URI and an explicit `inline` or `fullscreen` preference. Preserve `mcpAppResourceUri` independently in tool-call events, including when `mcpAppUi` is unset, and document the behavior. ## Testing Update integration coverage for explicit display modes, missing and unsupported preferences, and legacy resource URIs, checking tool-call events and resumed history. GitOrigin-RevId: 4876cced068d8e464adeb265abd053d8abe667ce
## Why An advertised control socket path can exceed the Unix socket path limit even when its symlink target is short enough to connect to. ## What changed On Unix, resolve the socket path and retry the connection when the initial attempt returns `InvalidInput`. ## Testing Add a regression test that creates control sockets under two long home paths, checks that their symlink targets are distinct, and verifies that clients can connect through both advertised paths. GitOrigin-RevId: 2541f0a9b02d85035fa89fe26bbcd36d5cd0cc1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )