Repository navigation
Fix authentication redirects and proxy handling for subfolder deployments - #258
Merged
Merged
Conversation
bifrost0x
marked this pull request as ready for review
October 9, 2026 07:07
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07378fd04b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and outcome
Authentication redirects can lose or duplicate a deployment prefix. Socket.IO also bypasses the existing ProxyFix wrapper, so HTTP and Engine.IO see different public connection details.
Normalize completed authentication return paths on the server and let browser handlers use those public paths directly. Apply ProxyFix before Socket.IO dispatch. Add bounded connection-error notices, admission diagnostics, and complete Apache/HAProxy examples.
Scope and links
Refs #257.
Three separate commits cover authentication redirects, ProxyFix ordering, and diagnostics/documentation/regression coverage. No release milestone assigned.
Validation
Tested file contents match head
07378fd04badd6292a9bca178f8fe633e9615e8c, based on94c16fef6f3178a068d223a50f0f21ef64d82d83./webssh,/tools/webssh, query preservation, unsafe targets, trust depths 0/1/2, authenticated polling, and negative origin/path checks.Root redirects retain their existing paths. Cookie settings, CORS configuration, worker count, and authentication requirements are unchanged. ProxyFix ordering intentionally also affects root deployments behind a reverse proxy, which must supply headers consistent with TRUSTED_PROXIES.