Skip to content

Menu action to export a watchonly wallet#872

Draft
achow101 wants to merge 9 commits intobitcoin-core:masterfrom
achow101:export-watchonly-wallet-gui
Draft

Menu action to export a watchonly wallet#872
achow101 wants to merge 9 commits intobitcoin-core:masterfrom
achow101:export-watchonly-wallet-gui

Conversation

@achow101
Copy link
Copy Markdown
Member

@achow101 achow101 commented May 13, 2025 •
edited
Loading

Allows a user to export a watchonly version of their wallet to be used in an airgapped setup.

Built on bitcoin/bitcoin#32489

@DrahtBot
Copy link
Copy Markdown
Contributor

DrahtBot commented May 13, 2025 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

This was referenced May 14, 2025
Merged
Merged
Merged
Merged
Merged
Open
Open
Open
Merged
Open
Merged
Merged
@achow101 achow101 force-pushed the export-watchonly-wallet-gui branch from 033db04 to da9365f Compare May 16, 2025 21:43
@achow101 achow101 force-pushed the export-watchonly-wallet-gui branch from da9365f to fe863d1 Compare May 20, 2025 00:56
@DrahtBot DrahtBot mentioned this pull request May 20, 2025
Merged
@hebasto hebasto changed the title gui: Menu action to export a watchonly wallet Menu action to export a watchonly wallet May 20, 2025
@achow101 achow101 force-pushed the export-watchonly-wallet-gui branch from fe863d1 to 6b252fe Compare May 21, 2025 17:54
This was referenced May 23, 2025
Merged
Merged
@DrahtBot DrahtBot mentioned this pull request May 31, 2025
Closed
@DrahtBot DrahtBot mentioned this pull request Jun 11, 2025
Merged
@DrahtBot DrahtBot mentioned this pull request Jun 20, 2025
Draft
@achow101 achow101 force-pushed the export-watchonly-wallet-gui branch from 7f318f0 to 22f3717 Compare September 11, 2025 22:40
This was referenced Sep 12, 2025
Merged
Draft
Closed
Open
Draft
@DrahtBot DrahtBot mentioned this pull request Dec 4, 2025
Merged
achow101 and others added 8 commits April 20, 2026 13:35
@achow101
descriptor: Add CanSelfExpand()
2f496d0 
CanSelfExpand() reports whether a descriptor can be expanded without
needing any caches or private keys to be provided by the caller of
Expand().
@achow101
wallet: Use Descriptor::CanSelfExpand() in CanGetAddresses()
056a35f 
If a descriptor does not need any caches or private keys in order to
expand, then CanGetAddresses() should return true for that descriptor.
@achow101
wallet: Write new descriptor's cache in AddWalletDescriptor
b3ba242 
If a new WalletDescriptor is provided to us with a cache, write the
cache to disk as well.
@achow101
wallet: Move listdescriptors retrieving from RPC to CWallet
e01da1c 
When listdescriptors retrieves the descriptors from the wallet, instead
of having this logic in the RPC, move it into CWallet itself. This
will enable other functions to get the descriptors in an exportable
form.
@achow101
wallet: Add CWallet::ExportWatchOnly
f41cbe8 
ExportWatchOnly produces a watchonly wallet file from a CWallet. This
can be restored onto another instance of Bitcoin Core to allow that
instance to watch the same descriptors, and also have all of the same
initial address book and transactions.
@achow101
wallet, rpc: Add exportwatchonlywallet RPC
86e2b1a
@achow101
test: Test for exportwatchonlywallet
764d021
@polespinasa @achow101
doc: update offline-signing-tutorial to use exportwatchonlywallet rpc
fc85c44
@achow101 achow101 force-pushed the export-watchonly-wallet-gui branch from 22f3717 to bd87e69 Compare April 28, 2026 17:43
@DrahtBot
Copy link
Copy Markdown
Contributor

DrahtBot commented Apr 28, 2026

🚧 At least one of the CI tasks failed.
Task tidy: https://github.com/bitcoin-core/gui/actions/runs/25068575825/job/73442374300
LLM reason (✨ experimental): CI failed because clang-tidy reported an bugprone-unused-return-value warning in qt/bitcoingui.cpp (neglecting a returned value), which was treated as an error.

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

  • Possibly due to a silent merge conflict (the changes in this pull request being
    incompatible with the current code in the target branch). If so, make sure to rebase on the latest
    commit of the target branch.

  • A sanitizer issue, which can only be found by compiling with the sanitizer and running the
    affected test.

  • An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

This was referenced Apr 29, 2026
Open
Open
Draft
@achow101 achow101 force-pushed the export-watchonly-wallet-gui branch from bd87e69 to 66824c5 Compare April 29, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@achow101 @DrahtBot @polespinasa