Repository navigation
Fix/ddl UI and tail settings - #36
Merged
Merged
Conversation
Preserve native scrolling, stable lane projection, card caching, storage migration and custom colors from main while retaining feature layout, UI and completion semantics.
Add a settings switch (on by default) that hides the left information card of ordinary events and exams in the timeline: its text, stripes and inner border disappear and the layout no longer reserves the lead, so back-to-back intervals share a lane. Real intervals, boundary lines and taps are untouched, and deadlines keep their own information cards. Restyle the visible information region: the inner half-line border now uses the accent color, and the 45-degree bands alternate between the solid fill and its half alpha instead of the previous .5/.25 pair. Completion fading still multiplies the existing alpha. Includes persistence, projection, pixel and settings-switch regressions.
Paint the real event/exam interval as 45-degree two-color bands that alternate the whole fill and the accent, the fill band first at the start line, both only faded by the completion factor. This reuses the shared stripe painter through a new optional secondColor. A hidden information card previously clipped the start indicator, which is drawn left of its time, against the surface now beginning exactly at the real start. The painted surface keeps one line width of lead in the hidden state so the start line stays visible at its true position; lane reservation stays at the real interval.
The settings ListView builds children lazily, so the switch row did not exist for ensureVisible yet.
A cascade expression is not a valid operand of a conditional expression; the release kernel compiler rejects it. Choose the band color into a local first.
The lessThan matcher needs the < operator, which DateTime does not implement; assert the exact projected start instead.
Use global layout width as the fallback for individual DDL tail lengths, restore the editor controls, and preserve overrides during sync. Restore legacy event boxes when information bars are disabled, simplify settings copy, and reuse the existing time picker for deadline cutoffs.
Expose a developer action to reset four-day DDL tails to null, including recycled entries, while retaining other widths and reporting the migrated count. Keep inheritance in the existing tailDays field and cover default editor state, persistence, repeated migration, and write failure recovery.
Paint every timeline card style from one caption helper, and let the existing AgendaEntry constants be the only source for the one to thirty day tail range. Also drop the preview status line that asked isFinished after done had already decided the card: completion separated from elapsed time in 90f0f69, so the ended state stayed unreachable and only the migrated history keeps it as completed. Card text, semantics, validation, persistence and error copy stay identical; the shared day marker also replaces the grid header's own copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boom