Skip to content

Fix Android build by using the shared time picker - #37

Closed
so1ve with Copilot wants to merge 28 commits into
mainfrom
copilot/fix-failing-github-actions-job-again
Closed

so1ve with Copilot wants to merge 28 commits into
mainfrom
copilot/fix-failing-github-actions-job-again

Conversation

Copilot AI commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

The Android build fails because the deadline cutoff screen imports a nonexistent dialog helper.

  • Picker: Use the shared time picker and forward localized endpoint labels.
  • Coverage: Check the help text for both cutoff endpoints.

PurpleRain-PR and others added 27 commits November 9, 2026 12:04
Preserve native scrolling, stable lane projection, card caching, storage migration and custom colors from main while retaining feature layout, UI and completion semantics.
Add a settings switch (on by default) that hides the left information
card of ordinary events and exams in the timeline: its text, stripes and
inner border disappear and the layout no longer reserves the lead, so
back-to-back intervals share a lane. Real intervals, boundary lines and
taps are untouched, and deadlines keep their own information cards.

Restyle the visible information region: the inner half-line border now
uses the accent color, and the 45-degree bands alternate between the
solid fill and its half alpha instead of the previous .5/.25 pair.
Completion fading still multiplies the existing alpha.

Includes persistence, projection, pixel and settings-switch regressions.
Paint the real event/exam interval as 45-degree two-color bands that
alternate the whole fill and the accent, the fill band first at the
start line, both only faded by the completion factor. This reuses the
shared stripe painter through a new optional secondColor.

A hidden information card previously clipped the start indicator, which
is drawn left of its time, against the surface now beginning exactly at
the real start. The painted surface keeps one line width of lead in the
hidden state so the start line stays visible at its true position;
lane reservation stays at the real interval.
The settings ListView builds children lazily, so the switch row did not
exist for ensureVisible yet.
A cascade expression is not a valid operand of a conditional
expression; the release kernel compiler rejects it. Choose the band
color into a local first.
The lessThan matcher needs the < operator, which DateTime does not
implement; assert the exact projected start instead.
Use global layout width as the fallback for individual DDL tail lengths, restore the editor controls, and preserve overrides during sync.

Restore legacy event boxes when information bars are disabled, simplify settings copy, and reuse the existing time picker for deadline cutoffs.
Expose a developer action to reset four-day DDL tails to null, including recycled entries, while retaining other widths and reporting the migrated count.

Keep inheritance in the existing tailDays field and cover default editor state, persistence, repeated migration, and write failure recovery.
Paint every timeline card style from one caption helper, and let the existing AgendaEntry constants be the only source for the one to thirty day tail range.

Also drop the preview status line that asked isFinished after done had already decided the card: completion separated from elapsed time in 90f0f69, so the ended state stayed unreachable and only the migrated history keeps it as completed.

Card text, semantics, validation, persistence and error copy stay identical; the shared day marker also replaces the grid header's own copy.
Co-authored-by: so1ve <58381667+so1ve@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job build (android, ubuntu-24.04) Fix Android build by using the shared time picker Nov 13, 2026
Copilot AI requested a review from so1ve November 13, 2026 06:25
@so1ve so1ve closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants