Repository navigation
Establish service-to-service API standards - #865
Merged
mike-gorman-bitwarden merged 25 commits intoSep 24, 2026
Merged
Conversation
mike-gorman-bitwarden
changed the title
Deploying contributing-docs with
|
| Latest commit: |
bad08b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f849b200.contributing-docs.pages.dev |
| Branch Preview URL: | https://docs-adr-0036-internal-api-s.contributing-docs.pages.dev |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
quexten
previously requested changes
Sep 16, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
"Internal" already names the client-facing API everywhere else at Bitwarden: the server repo splits its OpenAPI into public and internal documents and serves the latter at specs/internal/swagger.json, and public-api.md on this site calls the same surface the private API. The scope paragraph here had to disclaim the title to say which "internal" it meant. Service-to-service is the term ADR-0035 rule 4 now gates on and the term this document already used for the relationship, so the gate and the standard match without a mapping. Scope is stated as a caller test — whose callers are other Bitwarden services — rather than a reachability test, matching rule 4. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mike-gorman-bitwarden
changed the title
Ranges was the only wire-grammar section with no RFC 2119 keyword, while Filtering, Multi-value parameters, Sorting and Sparse fieldsets are all MUST. The escape rule for commas is already normative against this syntax, so the syntax itself has to be citable in review. Same for the all-caps enum convention, which sat unmarked in a bullet that ends with a MUST. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
withinfocus
requested changes
Sep 24, 2026
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Documentation-only change adding ADR-0036, which now proposes only that service-to-service APIs |
withinfocus
approved these changes
Sep 24, 2026
withinfocus
dismissed
quexten’s stale review
September 24, 2026 18:05
Deferred until the acceptance phase.
mike-gorman-bitwarden
deleted the
docs/adr-0036-internal-api-standards
branch
September 24, 2026 18:08
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establish the internal API standards of a service-oriented architecture.