Repository navigation
docs: update feature flag docs for Bitwarden.Server.Sdk.Features - #888
Merged
Merged
Conversation
The server now evaluates flags through Bitwarden.Server.Sdk.Features, so the server guidance referenced types and methods that no longer apply. Document team-owned flag key collections, AddFeatureFlagValues for code overrides, and the BW0001 code fix for flag removal.
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR changes only documentation, in |
Deploying contributing-docs with
|
| Latest commit: |
f8b7788
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82535d44.contributing-docs.pages.dev |
| Branch Preview URL: | https://docs-feature-flags-server-sd.contributing-docs.pages.dev |
justindbaur
marked this pull request as ready for review
October 9, 2026 18:41
withinfocus
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Follow-up to bitwarden/server#7898, which switched the server to
Bitwarden.Server.Sdk.Features.📔 Objective
Update the feature flag docs to reflect the server's move to
Bitwarden.Server.Sdk.Features:ServerContextBuilderand note device targeting.GetLocalOverrideFlagValues()guidance withAddFeatureFlagValues().[FlagKeyCollection]and team-owned flag key collections registered withAddKnownFeatureFlags()(which must happen inApifor flags returned from/config), instead of requiring every flag inFeatureFlagKeys.ICurrentContextrequirement from the server consumption steps and link to the package docs.Configuration examples intentionally still use the
globalSettings:launchDarklykeys.