Replace DeprecatedConstantProxy with const_missing for Dotenv::Railtie#545
Open
agrberg wants to merge 1 commit intobkeepers:mainfrom
Open
Replace DeprecatedConstantProxy with const_missing for Dotenv::Railtie#545agrberg wants to merge 1 commit intobkeepers:mainfrom
agrberg wants to merge 1 commit intobkeepers:mainfrom
Conversation
`DeprecatedConstantProxy` registers a real constant, which means static analysis tools like tapioca emit deprecation warnings when enumerating Dotenv.constants even if Dotenv::Railtie is never referenced. `const_missing` keeps the deprecation behavior for actual usage while hiding the constant from introspection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ActiveSupport::Deprecation::DeprecatedConstantProxywith aconst_missinghook onDotenvso thatDotenv::Railtieonly emits a deprecation warning when actually used in code, not when tools enumerateDotenv.constants:Railtieis not visible inDotenv.constantsCloses #544
Test plan
Dotenv::Railtiestill returnsDotenv::RailsDotenv::Railtieemits a deprecation warningDotenv.constantsdoes not include:Railtie🤖 Generated with Claude Code