WIP Ci zizmor#40
Open
blackboxsw wants to merge 13 commits into
Open
Conversation
…onical#6830) ssh-import-id has been experiencing high failure rates retrieving Launchpad-based SSH keys resulting in exit 1 which raises errors from cloud-init status. Use Github based keys instead as this backend doesn't appear to cause problems.
Also convert a few fake_filesystem tests to prove its usage: - tests/unittests/config/test_cc_keyboard.py - tests/unittests/config/test_cc_mounts.py - tests/unittests/config/test_cc_update_etc_hosts.py - tests/unittests/config/test_cc_puppet.py
Remove DataSourceOpenNebula and its unit tests from the mypy check_untyped_defs=false override list and add type annotations to satisfy stricter checking. Annotate parse_shell_config, OpenNebulaNetwork.__init__, get_field (with @overload to distinguish str vs Optional[str] return), all get_* methods, get_physical_nics_by_mac, and read_context_disk_dir (fixing its stale docstring). Remove test_get_field_nonecontext: shell variables cannot hold None values so the scenario is impossible; test_get_field_emptycontext covers the realistic equivalent. Remove leftover bare `util.find_devs_with` assignment in test_find_candidates, a refactoring artifact from d482353 that leaked state between tests. Refs canonicalGH-6810
…sk (canonical#6728) When checking GPT partition layout using sfdisk, handle the case where a disk has no partition table yet. Previously, this would raise an exception. Now it returns an empty list. Add unit test to cover this empty disk scenario. Fixes canonicalGH-6682 Signed-off-by: Amy Chen <xiachen@redhat.com>
Add a single retry on ssh-import-id to mitigate intermittent errors from remote service avoiding boot failures. Seeing 10-20% failure rate of exit 1's from ssh-import-id during instance launches in github action runners.
Adding amazon linux variant to cloud config. And Refreshing/Updating module values for Amazon Linux distro only. Namely cc_ca_cert and cc_yum_add_repo.
ONE_CONTEXT passes ETHx_MTU as a string, but Netplan's network-config-v2 schema requires mtu to be an integer. Without this, cloud-init schema validation fails with "'1500' is not of type 'integer'".
…canonical#6810) Add `get_routes()` to `OpenNebulaNetwork` to parse the `ETHx_ROUTES` context variable (format: "NETWORK via GATEWAY, ...") and emit the resulting routes into the Netplan v2 `routes:` list in `gen_conf()`. Malformed entries are skipped with a warning. No `routes` key is emitted when the variable is absent or empty, preserving backward compatibility.
Explanations did not match the code (or the opposite). Fixes canonicalGH-6857
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Merge type