Repository navigation
Conversation
|
Windows run of the manual acceptance from the description, against a real enforcing NIP-FI deployment (Block's), in case it helps with the "Windows native execution" item. Environment: Windows 11 Enterprise 10.0.26300, WebView2 156, existing Buzz identity, relay in NIP-FI enforce mode (plain WebSocket upgrade → 401). Builds made with the repo-pinned Rust 1.98.1 / pnpm 11.8.0, 1. The branch as-is needs a rebase. Built from 2. Rebased onto
Observations (not blockers):
Build note for Windows without admin: |
04df5c0 to
b130944
Compare
|
@corydouthat-sq Thanks for testing this and documenting the Windows results. I verified the lifetime check you identified and rebased onto upstream That also brings in the macOS Keychain bundling change. There were two conflicts against this newer base: the configuration docs and the session-store constructor. Both are resolved, preserving upstream's launch guidance and Checks on the rebased Mac checkout passed: 113 federation tests, 207 relay tests (2 existing ignored), the native import fixture, formatting, and the mandatory workspace Clippy check. Another 313 existing first-run/sign-in tests passed. Independent Claude Opus 5.5 review found no blockers. The description now credits your Windows acceptance against the build you tested, separately from our checks on this newer head. We're keeping the PR draft pending packaged Mac/real-Keychain/browser SSO testing, human acceptance and hosted CI. Headless Chromium/WebKit also confirmed the separate first-run limitation: an external community still offers Builderlab signup or an existing key. This rebase doesn't expand into that signup work. |
joahg
left a comment
There was a problem hiding this comment.
🤖 Read runtime.rs and the FederatedIdentity::open wiring. Compiled config short-circuits before the file is opened, and the Unix loader opens with O_NOFOLLOW, checks the handle's owner and mode, and bounds the read. The PR itself notes that maintainer agreement on this opt-in local trust model is needed; that decision is outside what I reviewed. Branch currently conflicts with main.
523fc46 to
2eba153
Compare
|
Rebased onto current main The important scope change upstream is the built-in The current CI run requires approval. I also reproduced an unrelated typecheck failure on clean main: the |
|
The current-head Mac live cycle is now complete on
This used the existing Keychain identity and an enforcing relay in an Apple silicon macOS VM. The validation section retains the packaging limit: this unsigned debug bundle required direct executable launch; Finder launch and signed distribution are not qualified. The zero-compiled-server scope and standard official-download limitation are unchanged. Upstream also fixed the unrelated build fixture in #2783. No additional code was pushed for this test. |
Co-authored-by: Codex <codex@openai.com> Signed-off-by: Nick <ci@kuhn-labs.com>
2eba153 to
804133e
Compare
A desktop deployment with its own NIP-FA/NIP-FI authority currently has to compile the authority into Buzz. This change lets a desktop built with an empty sign-in registry load one nonsecret descriptor,
federated-identity.json, from its existing federation store at startup. The configuration guide covers installation, permissions, and removal.A nonempty compiled registry takes precedence and Buzz never opens the local file. Standard downloads compile
bb-public. Standard and mixed registries retain Builderlab customer routing, saved customer hosts, and per-server session slots. A local descriptor selects a single authority and cannot enable Builderlab customer discovery, even if it copies the built-in descriptor.In a build with an empty registry, an absent file leaves federation unconfigured. An invalid or unreadable file stops startup. Unix checks the opened file's type, owner and write mode, refuses a symlink at the final component, and bounds the read. The operator must protect the parent path and ACLs. Windows relies on the user's application-data ACLs. Sessions keep their existing profile and descriptor fingerprint. Installed plugins still need a matching explicit grant.
Trust decision for review. Someone with write access as the user could place a descriptor and change which organization prompts for sign-in after restart. Is enabling that local choice for builds shipped with an empty registry acceptable? The earlier review left this decision to the project owners.
Validation on 804133e, rebased onto
3a1eb56. On November 9 I tested an unsigned arm64 debug bundle in a macOS VM with an existing Buzz identity and a relay that enforces NIP-FI. I built it from this commit with the pinned dependencies andBUZZ_BUILD_FEDERATED_IDENTITY_CONFIG=''. The guest executable matched the built binary (SHA-2562152b29ca1d7c536ab5b779a2bded539a7a0d4b5b0512ea1c2e6b598c21d93e9).The local checks passed: 152 native federation tests, 10 build-configuration tests, 231 relay tests (2 existing ignores), the import fixture, 245 renderer tests, formatting and the repository pre-push checks, including workspace Clippy. Regression coverage includes restoring a Builderlab customer after restart and opening that same store with a local-only descriptor. Independent static review by Claude Opus 5.5 found no blocking defect.
This run covers an existing Mac identity. Fresh enterprise signup, a signed distribution, and adding another authority to the standard download remain outside this change. The previous Mac run and contributor's Windows run cover earlier heads.
GitHub's proposed merge has the same source tree as the tested commit (
10087f0a131c0cc932a289c5c8d4a80f47709265). The hosted application CI run requires maintainer approval and has run zero jobs. Please approve that run so the project checks can execute.