Skip to content

fix(relay): align native signature verification arguments #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kalvinnchau merged 1 commit into from
Nov 3, 2026
Merged

fix(relay): align native signature verification arguments #2237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/features/relay/artifact-sync.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ describe("live socket sync wire", () => {
undefined,
undefined,
undefined,
undefined,
check,
);
const failed = { event: vi.fn(), eose: vi.fn(), closed: vi.fn() };
Expand Down
8 changes: 4 additions & 4 deletions src/features/relay/live.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ describe("native live verification", () => {

it("batches a burst without JS signatures and delivers valid events before EOSE and CLOSED", async () => {
const host = gate();
const h = setup(["a"], undefined, undefined, host.check);
const h = setup(["a"], undefined, undefined, undefined, host.check);
const delivered: string[] = [];
h.callbacks.receive.mockImplementation(([event], provenance) =>
delivered.push(`${event?.content}:${provenance?.phase}`),
Expand Down Expand Up @@ -215,7 +215,7 @@ describe("native live verification", () => {
"discards native results after %s",
async (action) => {
const host = gate();
const h = setup(["a"], undefined, undefined, host.check);
const h = setup(["a"], undefined, undefined, undefined, host.check);
try {
await h.first.auth();
const route = channelRequest(h.first);
Expand Down Expand Up @@ -248,7 +248,7 @@ describe("native live verification", () => {
nativeSignatureChecks({ claims }),
)
.mockRejectedValueOnce(new Error("host unavailable"));
const h = setup(["a"], undefined, undefined, check);
const h = setup(["a"], undefined, undefined, undefined, check);
try {
await h.first.auth();
const route = channelRequest(h.first);
Expand Down Expand Up @@ -280,7 +280,7 @@ describe("native live verification", () => {
vi.useFakeTimers();
vi.setSystemTime(1_700_000_000_000);
const host = gate();
const h = setup(["a"], undefined, () => 0, host.check);
const h = setup(["a"], undefined, undefined, () => 0, host.check);
try {
await h.first.auth();
for (const req of h.first.requests())
Expand Down
1 change: 1 addition & 0 deletions src/features/relay/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1414,6 +1414,7 @@ export async function connectSignedTransport(
undefined,
undefined,
undefined,
undefined,
signer.verifySignatures,
);
} catch (error) {
Expand Down
Loading