Skip to content

test(agents): align harness fixture with owner authorization #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kalvinnchau wants to merge 1 commit into from
Closed

test(agents): align harness fixture with owner authorization #2445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/features/agent-harness/kit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ describe("harnessKit.conversation", () => {
await kit.conversation(delivery({ type: "mention", event }), "thread"),
).toBeUndefined();
const workflow = message("3", "@Ampy go", {
pubkey: mallory,
tags: [
["h", channel],
["buzz:workflow", "w"],
Expand All @@ -187,6 +188,13 @@ describe("harnessKit.conversation", () => {
"thread",
),
).toBeUndefined();
// A marker alone neither grants authority nor revokes the owner's own.
expect(
await kit.conversation(
delivery({ type: "mention", event: { ...workflow, pubkey: alice } }),
"thread",
),
).toBeDefined();
expect(
await kit.conversation(
delivery({
Expand Down
2 changes: 1 addition & 1 deletion src/features/agent-harness/kit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export type HarnessPrompt = Readonly<{
export type HarnessKit = Readonly<{
/** The conversation a mention or a wake goes to. Undefined when the
* harness must not act on it: another trigger, a mention that is not the
* owner's own or attested by them (a workflow's never is), no channel, or a
* owner's own or attested by them, no channel, or a
* wake with no conversation to go to. */
conversation(
delivery: Delivery,
Expand Down
Loading