Repository navigation
Conversation
The relay now joins new members to channels flagged auto_join on invite claim and admission, so mobile no longer creates or joins the `general` and `welcome-everyone` starter channels itself. Remove MobileInviteJoinRecovery, the starter channel id derivation, the persisted Community.starterSetupIncomplete flag (old saved JSON that still carries the key keeps loading), the retry and recovery UI, and the focus on welcome-everyone after joining. A successful claim now goes straight to the success state, and the hosted flow no longer reruns setup for an incomplete community. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a3abc6163
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| state = state.copyWith( | ||
| status: InviteJoinStatus.success, |
There was a problem hiding this comment.
When an invite claim commits relay membership but any default-channel join has a transient failure, this path now reports success and removes the only client recovery mechanism. auto_join_default_channels explicitly catches these failures and still lets the claim return 2xx (crates/buzz-relay/src/handlers/side_effects.rs:3044-3047), while a later claim is already_member and does not rerun the joins (crates/buzz-relay/src/api/invites.rs:639-643). Since a repo-wide search finds no mobile handling of the advertised auto_join metadata, affected users can remain permanently absent from default channels; retain durable pending state or add session-time reconciliation before treating setup as complete.
AGENTS.md reference: AGENTS.md:L219-L226
Useful? React with 👍 / 👎.
The relay now joins new community members to default channels itself (#8594). A relay owner or admin flags a channel
auto_join, and the relay joins each new member on invite claim or admission. Mobile no longer needs its own starter-channel setup, where after an invite claim (or a hosted sign-in from an invite) it createdgeneralandwelcome-everyoneif they were missing and joined them.This PR removes that client-side setup:
Community.starterSetupIncompleteflag is gone. Saved communities that still have the key load normally, and the key is simply ignored.Validation
just mobile-checkandjust mobile-testpass. Starter-only tests were removed. The invite and hosted journeys now cover claim success, switching to an existing community, errors, policy acceptance, and the hosted flow without starter steps. I broke the no-reclaim guard once to confirm its test fails.generalandwelcome-everyonewere flagged auto-join andrandomwas not.generalandwelcome-everyonebut notrandom.welcome-everyonefrom a channel deep link and sent a message, which the relay received.invite.mp4
🤖 Generated with Claude Code