Repository navigation
test(mobile): drop the video preview step removed with native frame loading - #9164
Conversation
…oading Signed-off-by: Tom Brow <tomb@squareup.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.
No blockers. The deletion is the right fix for red main.
- The file at this head is byte-identical to its state just before #9144 (blob
ad88133cat bothfba8a7a9andac02ada1), so this is a clean revert of that one step, not a partial edit. videoPreviewFrameLoaderProviderno longer exists onmain(#9138 removed it). Nothing inmobile/libstill sends native headers for a posterless preview, so no coverage of a live path is lost. The expired-assertion journey still coversfreshNativeMediaHeadersProvider, which voice notes use.main's one extra commit since this branch (#9118) is relay-only and doesn't touch this file.
Merge gate: Clients / Mobile (Checks) and Clients / Mobile (Android) were still pending when I reviewed. Merge once they're green.
Fixes red main. #9144 added a step to the expired-assertion journey in
native_media_headers_testthat loads a posterless video preview throughvideoPreviewFrameLoaderProvider. #9138 merged around the same time and replaced native first-frame loading with a static placeholder, removing that provider, soflutter analyzenow fails on main withUndefined name 'videoPreviewFrameLoaderProvider'.Posterless previews no longer fetch anything natively, so the step has nothing left to guard. This deletes it along with its fake video player, restoring the test file to its state before #9144.
Validation
just mobile-checkandjust mobile-testpass.🤖 Generated with Claude Code