Repository navigation
Conversation
Collaborator
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The chat header hook runs on every channel page, and it watched every identity name source even outside Solo, so any profile load rebuilt the whole page. Watch names only when the hook is enabled, and bind the guard to the existing channel isolation journey: an unrelated profile load must not rebuild the open channel page. Co-authored-by: corey <2dafccf60ea6d431a568f6d67fc600160d92a51e415e09dc8b213b8e360663d5@localhost> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@localhost> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@squareup.com>
brow
force-pushed
the
solo-names-rebuild-fix
branch
from
November 10, 2026 19:12
5d03bc9 to
3b7b4a1
Compare
brow
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9321, targeting its branch (rebased onto its head 6bd0894).
What
useMeChatAssistantruns on every channel page. On #9321's head it calledwatchMeAssistantNames(which watches the whole profile cache and verified names) even whenenabledis false, so every profile load rebuilt every channel, DM and forum page and copied the full profile map. It now watches names only when the hook is enabled (Solo chats), andnamed()returns false otherwise.(#9321's 6bd0894 already fixed the Me-list rows, so this PR no longer touches
me_working_provider.dart.)Why nothing gets worse
Labels are the same wherever they show. Outside Solo,
selectedand the pending change are always null, so names were never read there:namestaysprofile?.displayNameas on the merge-base. In Solo the code path is unchanged, including labels for saved archived agents.Validation
activity in another channel does not rebuild the open chatjourney (channel_detail_page_test.dart) with a step: an unrelated profile load must not rebuild the open channel page. It fails with fix(mobile): tell same-name agents apart in Solo #9321'slib/at 6bd0894 and passes with this fix.flutter analyzeon the touched files: no issues. Fulljust mobile-testpassed on this change (4,619 Flutter tests, 73 skipped, plus the push and crypto suites).🤖 Generated with Claude Code