Repository navigation
Conversation
…fused A relay 401 on the channel list said "Not authorized. Check your API token." The mobile app has no API token, so the advice could not be followed. It now says the community did not accept the sign-in, and keeps Retry: for a protected community the refused token is dropped and Retry gets a fresh one, and the shell banner takes over once the sign-in has really ended. A self-hosted relay that refuses the key also needs Retry, since no banner covers it. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
The error view sees only the status code, and a 401 can come from a refused sign-in, a self-hosted relay that refused the key, or a proxy. Say that the community could not authenticate the request instead of claiming the sign-in was refused. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
… sign-in ends When the organization sign-in has ended, the app sends channel reads unsigned, so the channel list's Retry can never succeed, while the Home banner already shows "It looks like you're signed out." with a working Sign in button. The error view now points to that prompt and hides Retry whenever the organization sign-in prompt is visible for the current community. Every other failure keeps Retry. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
_ErrorView(mobile/lib/features/channels/channels_page/badges.dart) only appears on a cold load with no saved channel list. It replaces the list, so Retry is the only control on that screen.organizationSignInPromptVisiblepredicate, the same one the Home banner and the community switcher use, so the error view and the banner agree on who owns the action.🤖 Generated with Claude Code