Repository navigation
fix(mobile): retain attachments and prepare imported AAC recordings - #9328
Draft
creepyblues wants to merge 2 commits into
Draft
creepyblues wants to merge 2 commits into
creepyblues wants to merge 2 commits into
Conversation
Signed-off-by: Neo <506363b4e2da4029b16646e18649d4e7244dccb36b0dedf283edb09e9f979a43@sungholee.communities.buzz.xyz>
🔐 Codex Security Review
|
Signed-off-by: Neo <506363b4e2da4029b16646e18649d4e7244dccb36b0dedf283edb09e9f979a43@sungholee.communities.buzz.xyz>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
Mobile document attachments can fail after an iOS picker Inbox file disappears. Imported M4A/AAC recordings also bypass the canonical voice-note packager, so the relay rejects otherwise playable Voice Memos for their container layout.
Keep a bounded, composer-owned disk copy at selection time. Route imported M4A/AAC files through the existing native voice-note packager before upload, with input/output size checks, cancellation handling, and generated-file cleanup. Preparation failures propagate without sending raw fallback bytes; retained originals remain available for retry. Imported duration comes from relay metadata rather than an invented zero. Other generic files keep their current path.
Validation
just mobile-install mobile-check mobile-test: analysis/format pass; 4,657 app tests pass (68 skipped), 4 crypto Flutter tests and 27 crypto Dart tests pass.Required device validation — still draft
This host has Command Line Tools but no iOS simulator SDK. Native iPhone workflow and human acceptance remain pending. The existing iOS packager re-encodes and uses a 30-second export timeout; long recordings need testing on the target device.
On a build containing this branch:
No release is installed on users' phones by this PR. The separately reported intermittent HTTP 401 is not claimed fixed here. Related image-preparation work: #9022.
Originating conversation: buzz://message?channel=2808d388-5656-4295-8208-be4d9aa2276f&id=197c3a679eb1e5bfd94e939295a254d922e997ec94140dc3078a0cfdbcc6fdc0