Skip to content

fix(mobile): use pink dots for unread activity - #9330

Draft
hitanshup wants to merge 1 commit into
block:mainfrom
hitanshup:hitanshu/112026_mobile_unread_pink
Draft

hitanshup wants to merge 1 commit into
block:mainfrom
hitanshup:hitanshu/112026_mobile_unread_pink

Conversation

@hitanshup

@hitanshup hitanshup commented Nov 10, 2026 •

Copy link
Copy Markdown

Why are we making this change?

Unread activity should be equally easy to spot on mobile and desktop. This brings the pink dot treatment from buzz-app#3218 to the shared Flutter app for iOS and Android.

What changed

Activity rows and the shared channel/DM tile use a dedicated AppColors.unread role: magenta in light mode and lighter pink in dark mode, independent of the chat accent. Existing dot visibility, read-state behavior, text styling and accessibility labels are preserved.

Validation

  • Existing Activity and channel-list journeys check the dot color in both themes, including clearing unread state through reading and Mark Read. A theme test checks at least 3:1 contrast against the list surface.
  • Restoring both old color references makes all three affected color journeys fail; restoring the change passes the focused suite (122 tests).
  • just mobile-install mobile-check mobile-test: passed. The final sequential run passed 4,655 main tests (68 skipped), four unconfigured-push tests, and 27 crypto tests. Static analysis passed with no issues.
  • Post-commit sq agents review: no findings.
  • Hosted Codex code review completed on 72327e0fd with no findings.
  • Android: debug app built and launched on the existing Android 16 emulator; hot reload applied the final colors. Live-account verification and human acceptance are pending.
  • iOS: runtime launch is blocked by missing CocoaPods. The changed Dart widgets and theme are shared by both platforms; no native code changed.

Screenshots

Before/after Activity screenshots were captured using the existing Flutter widget fixture with synthetic data. Uploading through the repository screenshot script requires upstream write access; this account has read-only access, so screenshot attachment remains pending a maintainer. No live community content was uploaded.

Manual check

In Activity, find an unread thread, mention or DM and confirm its dot is pink. In the channel/DM list, confirm existing attention dots are pink. Switch between light and dark mode, then read or mark an item read and confirm its dot clears as before. Muted and read rows retain their existing dot visibility.

This PR remains draft pending live-account/human verification, screenshot attachment, and maintainer authorization for fork CI and the repository's separate security-review workflow.

Signed-off-by: Hitanshu Paruthi <hitanshu@squareup.com>

Copy link
Copy Markdown
Author

🤖 @codex review

@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Status: review required for the current range.

The current range is b40f22114bac744d91c8afb25d644826646fb776...72327e0fd3ae41c1137b8c7d3f2c83c25bc579ce.
A new review must complete for this exact range. When manual authorization
is required, a user with write access must comment exactly
@buzz-security-review 72327e0fd3ae41c1137b8c7d3f2c83c25bc579ce to authorize a new review.
Any previous review applies only to its recorded range.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T18:58:32.269071Z 72327e0 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 72327e0fd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant