Repository navigation
Conversation
Signed-off-by: Hitanshu Paruthi <hitanshu@squareup.com>
|
🤖 @codex review |
🔐 Codex Security Review
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Why are we making this change?
Unread activity should be equally easy to spot on mobile and desktop. This brings the pink dot treatment from buzz-app#3218 to the shared Flutter app for iOS and Android.
What changed
Activity rows and the shared channel/DM tile use a dedicated
AppColors.unreadrole: magenta in light mode and lighter pink in dark mode, independent of the chat accent. Existing dot visibility, read-state behavior, text styling and accessibility labels are preserved.Validation
just mobile-install mobile-check mobile-test: passed. The final sequential run passed 4,655 main tests (68 skipped), four unconfigured-push tests, and 27 crypto tests. Static analysis passed with no issues.sq agents review: no findings.72327e0fdwith no findings.Screenshots
Before/after Activity screenshots were captured using the existing Flutter widget fixture with synthetic data. Uploading through the repository screenshot script requires upstream write access; this account has read-only access, so screenshot attachment remains pending a maintainer. No live community content was uploaded.
Manual check
In Activity, find an unread thread, mention or DM and confirm its dot is pink. In the channel/DM list, confirm existing attention dots are pink. Switch between light and dark mode, then read or mark an item read and confirm its dot clears as before. Muted and read rows retain their existing dot visibility.
This PR remains draft pending live-account/human verification, screenshot attachment, and maintainer authorization for fork CI and the repository's separate security-review workflow.