fix(handler): vary cache key by Accept-Encoding to prevent cache poisoning#310
Open
joshfriend wants to merge 1 commit into
Open
fix(handler): vary cache key by Accept-Encoding to prevent cache poisoning#310joshfriend wants to merge 1 commit into
joshfriend wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b0b1c7032
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
joshfriend
force-pushed
the
jfriend/fix-transport-headers
branch
from
9b0b1c7 to
a68085f
Compare
…oning Introduce CacheKeyParts to cleanly separate the cache key path from request-derived dimensions like Accept-Encoding. Upstreams like dl.google.com return different content based on Accept-Encoding, and without this the first variant cached gets served to all clients.
joshfriend
force-pushed
the
jfriend/fix-transport-headers
branch
2 times, most recently
from
a68085f to
17268cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
CacheKeyPartsto cleanly separate the cache key path from request-derived dimensions likeAccept-Encoding. Upstreams like dl.google.com return different content based onAccept-Encoding, and without this the first variant cached gets served to all clients.