Repository navigation
Export complete reference candidates for reviewed integrations - #21
Closed
daveh-beep wants to merge 1 commit into
Closed
daveh-beep wants to merge 1 commit into
daveh-beep wants to merge 1 commit into
Conversation
Signed-off-by: David Hamilton <daveh@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What observed experience does this improve?
An integration using the existing index or search output cannot read the complete reference, including inline
mustrules, exceptions, exact wording, and approval scope.Learning check
This is an optional deterministic tooling change; setup, reference contracts, and drafting behavior are unchanged. On Python 3.9.6,
python3 -B -m unittest discover -s tests -vpasses all 48 tests. The fresh independent reviewer also reran the 30 corpus tests.test_export_preserves_complete_original_bytes_and_leaves_index_unchangeduses a synthetic UTF-8 reference with CRLF, comments, inline enforcement, scoped exact wording, and trailing whitespace. The failure criterion is any difference between decoded exported text and original bytes/hash/length; index and search outputs are unchanged controls. Other executed cases cover malformed input, missing or invalid revisions, ingestion limits, excluded calibration and instruction files, empty coverage, and refusing to overwrite output. These tests establish transport and structural behavior, not model adherence or writing quality.Changes
corpus.py export --reported-revision <full Git object ID>with complete original source text, existing metadata, byte counts, and SHA-256 hashes.check/index/searchoutputs unchanged.Related groundwork: Ghost scoped language references. Each change works independently.
Additional validation:
bash checks/adversarial-contract.sh, template/Meridian/Harbor corpus checks, export help, andgit diff --checkpass. A synthetic transport check selected the fictional Meridian terminology reference from the real export and delivered it through Ghost's JSON and Markdown pull commands, preserving full text and scope. This does not establish an approved consumer integration.Safety and verification
git commit -s).