Skip to content

chore: migrate to changesets action v2 inputs - #41

Open
trueberryless wants to merge 4 commits into
bombshell-dev:mainfrom
trueberryless:chore/changesets-action-v2
Open

trueberryless wants to merge 4 commits into
bombshell-dev:mainfrom
trueberryless:chore/changesets-action-v2

Conversation

@trueberryless

@trueberryless trueberryless commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Bumps the Changesets GitHub action to v2.1.2, fixes the input parameters and drops the Dependabot ignore rule again.
Also see this section in the migration guide: https://changesets.dev/guide/migration#update-inputs

Callers need @changesets/cli v3, repos still on v2 should pin 0c11c22d (noted in docs/publish.md). I kept the new default of pushing release commits through the GitHub API instead of setting push-with-git-cli: true.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • All tests pass (pnpm test)
  • Files are formatted (pnpm format)
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

There are no tests in this repo.

AI-generated code disclosure

  • This PR includes AI-generated code

@dreyfus92 dreyfus92 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks right against v2.1.2's action.yml, but v2 also hard-fails when the root @changesets/cli is 2.x (validateChangesetsCliVersion runs before the input checks). tab, args and clink use this @main and are all on ^2.x, so they'd still fail after this merges. clack and tools are pinned to an older sha so they're fine for now. i'd either pin back to v1.9.0 until callers move to cli v3, or ship this together with the cli bumps. also worth a dependabot ignore for majors on changesets/action.

cc. @natemoo-re

@trueberryless

Copy link
Copy Markdown
Member Author

diff looks right against v2.1.2's action.yml, but v2 also hard-fails when the root @changesets/cli is 2.x (validateChangesetsCliVersion runs before the input checks). tab, args and clink use this @main and are all on ^2.x, so they'd still fail after this merges. clack and tools are pinned to an older sha so they're fine for now. i'd either pin back to v1.9.0 until callers move to cli v3, or ship this together with the cli bumps. also worth a dependabot ignore for majors on changesets/action.

cc. @natemoo-re

AH, thanks for checking that, I only looked at clack. I would prefer to pin those three to back to v1.9.0 because then we have no rush in creating, merging, reviewing all those PRs simultaneously. I think we should take it slow 👍

I created #42 for this reason!

@trueberryless
trueberryless marked this pull request as draft November 4, 2026 07:04
@trueberryless
trueberryless force-pushed the chore/changesets-action-v2 branch from 3fe149e to c151b9f Compare November 6, 2026 22:12
@trueberryless

Copy link
Copy Markdown
Member Author

Alright, I rebased this PR and also decided to remove the dependabot ignore rule again because once we update to action v2, we don't need the rule anymore. There may be an argument to keep it because future major releases of the action would probably break again, but then I would say that we should rather block dependabot from doing any major updates at all. wdyt?

(btw, this is still a draft because we need these PRs merged first in order to safely proceed:

)

@trueberryless
trueberryless marked this pull request as ready for review November 16, 2026 17:14

@dreyfus92 dreyfus92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @trueberryless for all the prs pinning stuff, code looks complete to me. two things i'd add before merging: a line in docs/publish.md saying callers on @main need @changesets/cli v3 (and cli v2 repos should pin to 0c11c22d until they migrate), and an updated pr body since it now bumps v1.9.0 to v2.1.2 and drops the dependabot rule too. also worth noting that v2 pushes release commits and tags through the github api instead of git cli by default, so they'll be signed and attributed to the app. set push-with-git-cli: true if you want the old behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants