Repository navigation
chore: migrate to changesets action v2 inputs - #41
trueberryless wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
diff looks right against v2.1.2's action.yml, but v2 also hard-fails when the root @changesets/cli is 2.x (validateChangesetsCliVersion runs before the input checks). tab, args and clink use this @main and are all on ^2.x, so they'd still fail after this merges. clack and tools are pinned to an older sha so they're fine for now. i'd either pin back to v1.9.0 until callers move to cli v3, or ship this together with the cli bumps. also worth a dependabot ignore for majors on changesets/action.
cc. @natemoo-re
AH, thanks for checking that, I only looked at I created #42 for this reason! |
3fe149e to
c151b9f
Compare
|
Alright, I rebased this PR and also decided to remove the dependabot ignore rule again because once we update to action v2, we don't need the rule anymore. There may be an argument to keep it because future major releases of the action would probably break again, but then I would say that we should rather block dependabot from doing any major updates at all. wdyt? (btw, this is still a draft because we need these PRs merged first in order to safely proceed:
) |
dreyfus92
left a comment
There was a problem hiding this comment.
thank you @trueberryless for all the prs pinning stuff, code looks complete to me. two things i'd add before merging: a line in docs/publish.md saying callers on @main need @changesets/cli v3 (and cli v2 repos should pin to 0c11c22d until they migrate), and an updated pr body since it now bumps v1.9.0 to v2.1.2 and drops the dependabot rule too. also worth noting that v2 pushes release commits and tags through the github api instead of git cli by default, so they'll be signed and attributed to the app. set push-with-git-cli: true if you want the old behavior.
What does this PR do?
Bumps the Changesets GitHub action to v2.1.2, fixes the input parameters and drops the Dependabot ignore rule again.
Also see this section in the migration guide: https://changesets.dev/guide/migration#update-inputs
Callers need
@changesets/cliv3, repos still on v2 should pin0c11c22d(noted indocs/publish.md). I kept the new default of pushing release commits through the GitHub API instead of settingpush-with-git-cli: true.Type of change
Checklist
pnpm test)pnpm format)There are no tests in this repo.
AI-generated code disclosure