Repository navigation
fix(prompts): use settings.messages.cancel when cancel() has no message - #643
Open
IG-ABHINAV wants to merge 1 commit into
Open
IG-ABHINAV wants to merge 1 commit into
IG-ABHINAV wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: f32932b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
From #642:
canceldefaulted itsmessageparameter to'', sosettings.messages.cancelwas never read. The spinner and progress bar already fall back tosettings.messages.cancel.Closes #642
How
packages/prompts/src/messages.ts:messageis now optional and the rendered text ismessage ?? settings.messages.cancel. An explicit string (including'') is still printed as given. JSDoc notes the default.packages/prompts/test/messages.test.ts(new): explicit message; no message → defaultCanceled; no message afterupdateSettings({ messages: { cancel: 'Operation cancelled' } })→ that message; explicit''still renders empty.@clack/promptspatch.Verification
Full
@clack/promptssuite,mainvs this branch (Node 24.22.1 locally, not the.nvmrc20.18.1):The same 13 tests fail on
mainwithout this change (autocomplete/password/path tab-completion and cursor rendering;@clack/corehas 5 similar failures, e.g.expected 'foo█' to equal 'foo'), so they look environment-related; the failing set is identical before and after.Judgment calls
cancel()with no argument now prints the defaultCanceledinstead of an empty line. That is what the i18n docs describe and matches the spinner's cancel fallback; callers who want no text can pass''.??rather than||so an explicit empty string keeps its current meaning.Type of change
Checklist
pnpm testpasses (or targeted tests for my change) — targeted tests pass; see the note above on pre-existing local failurespnpm formathas been run (biome check clean on changed files)AI-generated code disclosure