Skip to content

Add node parent relationships and basic insertion - #58

Merged
cowboyd merged 1 commit into
mainfrom
dom-tree-insertion
Nov 11, 2026
Merged

cowboyd merged 1 commit into
mainfrom
dom-tree-insertion

Conversation

@cowboyd

@cowboyd cowboyd commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Track parentNode and parentElement while inserting, moving, and removing child nodes. Route appendChild through insertBefore and enable four WPT cases covering detached parent relationships, invalid anchors, and insertion before self. Stacked on #56.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • All tests pass (pnpm test)
  • Files are formatted (pnpm format)
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

@pkg-pr-new

pkg-pr-new Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/bombshell-dev/ui/@clack/ui@58

commit: 09ab8e8

@cowboyd
cowboyd marked this pull request as ready for review November 11, 2026 16:10
@cowboyd
cowboyd added this pull request to stack #57 November 11, 2026 16:11
@codspeed

codspeed Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 240 untouched benchmarks


Comparing dom-tree-insertion (09ab8e8) with main (aa3e927)

Open in CodSpeed

Base automatically changed from dom-character-data to main November 11, 2026 17:44
@cowboyd
cowboyd requested a review from natemoo-re November 11, 2026 18:17
@cowboyd
cowboyd merged commit baa93e3 into main Nov 11, 2026
10 checks passed
@cowboyd
cowboyd deleted the dom-tree-insertion branch November 11, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants