Repository navigation
Support namespace-aware element creation - #64
Merged
Merged
Conversation
cowboyd
force-pushed
the
wpt-create-element-ns
branch
from
November 11, 2026 20:57
18ca180 to
337f184
Compare
commit: |
6 of 12 tasks
cowboyd
marked this pull request as ready for review
November 12, 2026 16:59
cowboyd
force-pushed
the
wpt-create-element-ns
branch
from
November 12, 2026 17:16
b3c0bf1 to
3245518
Compare
natemoo-re
approved these changes
Nov 12, 2026
cowboyd
force-pushed
the
wpt-create-element-ns
branch
from
November 12, 2026 21:16
3245518 to
895745f
Compare
cowboyd
force-pushed
the
wpt-create-element-ns
branch
from
November 12, 2026 21:17
895745f to
9979d05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preact requires
document.createElementNS(), so this PR adds it with namespace normalization, qualified-name validation, and namespace-aware element names.In order for the test to run it needs also the
HTMLElement,HTMLSpanElement, andHTMLUnknownElementconstructors to ensure that we got the right namespace. This is ok, because we'll eventually need it to support custom elements.Type of change
Checklist
pnpm test)pnpm format)AI-generated code disclosure