Repository navigation
Implement XML document creation for native WPT setup #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+43
−3
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -222,8 +222,30 @@ export class DOMImplementation { | |
| this.#notify = notify; | ||
| } | ||
|
|
||
| createDocument(): Document { | ||
| return new Document(this.#notify); | ||
| // oxlint-disable-next-line bombshell-dev/max-params -- DOMImplementation.createDocument uses three positional arguments. | ||
| createDocument( | ||
| namespace: string | null, | ||
| qualifiedName: string | null, | ||
| doctype: DocumentType | null = null, | ||
| ): XMLDocument { | ||
| if (arguments.length < 2) { | ||
| throw new TypeError('createDocument requires a namespace and qualified name'); | ||
| } | ||
| const namespaceURI = namespace == null ? null : `${namespace}` || null; | ||
| const name = qualifiedName === null ? '' : `${qualifiedName}`; | ||
| if (doctype !== null && !(doctype instanceof DocumentType)) { | ||
| throw new TypeError('createDocument requires a DocumentType or null for its doctype'); | ||
| } | ||
|
|
||
| const document = new XMLDocument(this.#notify); | ||
| const element = name === '' ? null : document.createElementNS(namespaceURI, name); | ||
| if (doctype !== null) { | ||
| document.appendChild(doctype); | ||
| } | ||
| if (element !== null) { | ||
| document.appendChild(element); | ||
| } | ||
| return document; | ||
| } | ||
|
|
||
| createHTMLDocument(title?: string): HTMLDocument { | ||
|
|
@@ -740,3 +762,7 @@ export class HTMLBodyElement extends HTMLElement {} | |
| export class HTMLSpanElement extends HTMLElement {} | ||
|
|
||
| export class HTMLUnknownElement extends HTMLElement {} | ||
|
|
||
| /** XML */ | ||
|
|
||
| export class XMLDocument extends Document {} | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lmao as much as i love html, i hate html
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Worse is better 😆 |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.