Repository navigation
Add Document.querySelector for native WPT fixture lookup - #86
Merged
Merged
Conversation
3 of 9 tasks
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
cowboyd
marked this pull request as ready for review
November 17, 2026 05:12
This was referenced Nov 17, 2026
cowboyd
force-pushed
the
dom-document-selectors
branch
from
November 17, 2026 21:43
21d311f to
9627b11
Compare
cowboyd
force-pushed
the
dom-document-selectors
branch
2 times, most recently
from
November 17, 2026 22:01
802c386 to
d3e154c
Compare
natemoo-re
approved these changes
Nov 18, 2026
| }, | ||
|
|
||
| getParent(node): Node | null { | ||
| return node.parentNode; |
Member
There was a problem hiding this comment.
Should this be node.parentElement? I didn't check the adapter interface but this surprised me
Contributor
Author
There was a problem hiding this comment.
Turns out that css-select is expecting any and all nodes and does explicit checking if it is an element. 🤷🏻♂️
cowboyd
force-pushed
the
dom-document-selectors
branch
from
November 18, 2026 02:41
d3e154c to
e5eee13
Compare
cowboyd
force-pushed
the
dom-document-selectors
branch
from
November 18, 2026 02:43
e5eee13 to
b9038b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See #87 for the endgame.
We want to run WPT test cases directly without any changes to the upstream and without hosting hundreds approximations of those tests in our repository.
The element-creation files use
document.querySelector()to locate iframe fixtures during shared setup, even when only their HTML-document cases are selected.Add
Document.querySelector()through the css-select adapter, returning the first match ornulland converting selector compilation errors toSyntaxError. The adapter is reused unchanged from the earlier selector work. See the DOM specification's scope-matching algorithm.Type of change
Checklist
AI-generated code disclosure