Repository navigation
An unbuilt stage of approved work is open, never parked - #637
Merged
Merged
Conversation
A later phase, 'PR N' or follow-up pull request of a design the user approved is written as its own open ledger line that starts 'Approved, not built:', is a candidate for the offer when the stage before it lands and on every 'next?', and is the project's list (no issue). check-open-work.mjs lists such lines and reports a deferred one as a finding; hr-what-next's floor and hr-handoff's reconciliation reference name them.
bompus
added
author:anthropic
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/in/5532859?s=60&v=4){kind=small}
…r without counting as an open one, and keeps its whole text in the report An open stage line that names the offer approving it no longer counts as an unanswered offer; the 'approved, not built' group prints the whole line so the trigger is not cut at 90 characters; the rule asks for a trailing 'trigger:' (which the stop hook already reads as a wait) and 'recheck:' for another thread, and says a session that lands a stage reads the plan holding the next one.
There was a problem hiding this comment.
Bompus AI Review (GPT-6.1 Terra, max reasoning): 5 finding(s).
Review 2: findings below high are posted only within 3 lines of a change since b155c93.
…nt a pending stage offer The rule no longer says the line ends with trigger:, which collided with done-when's last-field rule; a stage line that says its offer was asked and is pending counts as an unanswered offer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stages of approved designs ("PR 5" of a staged design) were recorded in a PR body or a doc line, or filed as parked, where no "next?", offer or handoff check reads them, and were forgotten. A parked item is excluded from every "next?" and offer, so an unbuilt stage filed there cannot resurface.
rules/core.md§ Session purpose: an unbuilt stage of work the user approved (a later phase, "PR N", a follow-up pull request of an approved design) is open work, never parked. When deferred it is written as its own open ledger line (- [ ]) that starts "Approved, not built:" and names the stage and what it waits on. These lines are the project's list, kept in the plan's Ledger; no issue is created unless the user asks. § End of every reply case 2 adds the next unbuilt stage of approved work to the offer candidates (so it also surfaces when the stage before it lands and on every "next?").skills/hr-what-next/SKILL.md: the open-work floor includes every open "Approved, not built:" line.skills/hr-what-next/scripts/check-open-work.mjs: new group "approved, not built" (open lines only), counted in the result line; a deferred ([~]) line that starts this way is a finding. Test added first (failed before the change).skills/hr-handoff/references/reconciliation.md: one sentence saying the checker carries these lines forward like any open line. The checker's interface is unchanged.Checks:
bun run checkpassed;bun test test/1,303 passed, 0 failed;bun test skills/990 passed, 0 failed.