Repository navigation
Wording fixes from four parked review points - #638
Merged
Merged
Conversation
web-image-formats: use a version parameter the image host does not own, leave URLs whose host uses v, and a branch-pointing URL can show old bytes for up to five minutes in a pull request preview. hr-diagnosing-bugs: the necessity test compares occasions with the other inputs and state alike. hr-sqlite rerun rows: the ratios are indicative because the observer rejected those phases. multi-agent: the background-work read-back clamps each start to 0 and stops at 0.
bompus
added
author:anthropic
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/in/5532859?s=60&v=4){kind=small}
…he merge; the five-minute cache is after it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four wording fixes from private-reviewer points on landed text (each point was recorded against its own pin and the owner approved them as one group):
rules/references/web-image-formats.md: use a version parameter the image host does not own and leave a URL alone whose host already usesv(bumpingNwould change what it returns); a URL that points at a branch (.../main/...) and is bumped in the same commit can still show old bytes for up to five minutes when a pull request is previewed before the merge. Added as its own short paragraph.skills/hr-diagnosing-bugs/references/evidence-discipline.md: the necessity test compares occasions with the other inputs and state alike; an occasion that differs in another input tests nothing. The paragraph is split so no block exceeds 900 characters.skills/hr-sqlite/references/evidence.md: the rerun's synchronous and copy ratios are labelled indicative, because the observer rejected those phases (for the workload's own I/O pressure); the admission note says so too.rules/references/multi-agent.md: the background-work read-back starts at max(0, N minus 120), then max(0, N minus 240), and stops when the start reaches 0.Checks:
bun run checkpassed;bun test test/1,308 passed, 0 failed;bun test skills/995 passed, 0 failed.