Repository navigation
Seat client: a Codex seat keeps MODEL_PROVIDER; a large saved diff leaves out protected paths - #640
Merged
Merged
Conversation
…aves out protected paths codex-acp reads MODEL_PROVIDER to choose the provider for new sessions and the narrowed seat environment dropped it. reviewer-role.md says the parent leaves secrets, .env files and credentials out of a large diff it saves into the review root, and lists what it left out.
bompus
added
author:anthropic
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/in/5532859?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two points from the private reviewer's read of the seat client, approved by the owner (parked lines on the seat launch and the reviewer role). Credential-handling code, so this PR carries
review:unfiltered.skills/hr-code-review/scripts/seat-launch.mjs: a Codex seat keepsMODEL_PROVIDER. codex-acp 2.6.0 reads it to choose the model provider for new sessions (its README "Runtime options" anddist/index.jsstartAcpServer), and the narrowed seat environment dropped it, so a seat could not use the provider the caller selected. It is a provider name, not a path. Only the Codex seat keeps it;INITIAL_AGENT_MODE(the client sets the seat's mode itself) andDEFAULT_AUTH_REQUESTstay out. Test added first (failed before the change);references/acp-client.mdnames it in the login list.skills/hr-code-review/references/reviewer-role.md: the parent leaves secrets,.envfiles and credentials out of a large diff it saves into the review root, and lists what it left out, because a saved diff is as readable to the reviewer as any file in the root.Checks:
bun run checkpassed;bun test test/1,309 passed, 0 failed;bun test skills/996 passed, 0 failed.